Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Desk Sidebar [2018-code-sprint] [Desk 2.0] #6661

Closed
wants to merge 2 commits into from

Conversation

johnhkelley1
Copy link
Contributor

A left-anchored sidebar that displays the desktop icons on all pages, allowing for quick and easy navigation.

desk-sidebar

Users can enable Desk Sidebar as an alternative to the traditional Desktop in their user settings. When the sidebar is enabled, users can choose a custom homepage. In addition, desk will take on a fluid, full-width layout to maximize screen space.

Users can also switch to a full-width layout while maintaining traditional Desktop navigation by manually enabling it in their user settings.

sidebar-settings

Discussion: https://discuss.frappe.io/t/desk-2-0-getting-started/83

A left-anchored sidebar that displays the desktop icons on all pages,
allowing for quick and easy navigation.

Users can enable Desk Sidebar as an alternative to the traditional
Desktop in their user settings. When the sidebar is enabled, users can
choose a custom homepage. In addition, desk will take on a fluid,
full-width layout to maximize screen space.

Users can also switch to a full-width layout while maintaining
traditional Desktop navigation by manually enabling it in their user
settings.

Co-authored-by: John Kelley <johnhkelley1@gmail.com>
Co-authored-by: Tyler Matteson <tyler@agritheory.com>
@parsimonyERP
Copy link

👍 Beautiful!

@agritheory
Copy link
Contributor

This would not have been possible without the layouts and styling of @joshreeder or the assist during the 2018 code sprint from @netchampfaris on how to incorporate this into the framework.

@mslake
Copy link

mslake commented Jan 26, 2019

This looks really great! Nice work guys.

@sagarvora sagarvora changed the title Desk Sidebar [2018-code-sprint] [Desk 2.0] feat: Desk Sidebar [2018-code-sprint] [Desk 2.0] Jan 29, 2019
@rmehta
Copy link
Member

rmehta commented Feb 7, 2019

@johnhkelley1 👍 for setting this out.

I was hoping @netchampfaris would review this, but apparently he has been very busy.

Unfortunately, the proposal is to kill Desktop Icons altogether in develop, so this cannot be merged.

My personal view of the design is that this is a permanent distraction on the screen and adds to the clutter. It works for people whose primary job is to click around, but does not help for more people who want to have focus.

I would recommend you can move this to a custom app and publish it on the forum for those who want to use this.

Edit: I hope this does not deter you from future contributions. We have a whole bunch of projects that got scrapped (https://github.com/frappe/archives) and this list is not even complete!

@rmehta rmehta closed this Feb 7, 2019
@clarkejj
Copy link
Contributor

clarkejj commented Feb 8, 2019

Thanks for this contribution John, Josh and Tyler - I encourage you to be persistent.

"I would recommend you can move this to a custom app and publish it on the forum for those who want to use this."

This option of a trial opportunity for what you propose may very well prove popular

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants